Conversation
58058dd to
94ffc4c
Compare
|
What license is for |
free for use as lib, donations welcomed if helpful for corporate clients :) |
ed7f311 to
937c220
Compare
tests/ContainsManyTest.php
Outdated
| foreach ($m->ref('lines') as $line) { | ||
| $total += $line->get('total_gross') * $line->get('discounts_percent') / 100; | ||
| foreach ($m->lines as $line) { | ||
| $total += $line->total_gross * $line->get('discounts_percent') / 100; |
There was a problem hiding this comment.
could be also $line->discounts_percent, right?
There was a problem hiding this comment.
Of course! About 1000 more replaces ;-)
Working with PHPStan team to fix Model iterator support, then probably replace everything with Rector.
There was a problem hiding this comment.
discussion here: phpstan/phpstan#4220 (reply in thread)
DarkSide666
left a comment
There was a problem hiding this comment.
Real magic, but looks good to use and interesting as a bit different coding example.
Also important that it's 100% BC, so if you don't want to use this magic in your code - no worries.
|
Really good @mvorisek. |
Probably not in data directly, but in atk4/core because we can maybe use similar approach for atk4/ui controls too. |
1d8dd02 to
a37a9bc
Compare
a37a9bc to
e76f2c7
Compare
see how to use in atk4/ui#1559
then we can convert all tests to it