Add loadany() to Array_ Persistence#715
Merged
mvorisek merged 3 commits intoatk4:developfrom Sep 18, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge after #690 or close (if #690 adds
loadAny)This method has somehow been missing from Persistence\Array_. This PR adds it and adds a few tests.
However, I see there should be some cleaning up done in PersistenceArrayTest.php in another PR:
Some functions in there are general Persistence tests and have nothing to do with Persistence\Array_.
My proposal is to move PersistenceArrayTest and PersistenceSQLTest to a new directory tests/Persistence/ to meet the structure in /src dir.