Skip to content

Upgrade phpunit#561

Merged
DarkSide666 merged 8 commits intodevelopfrom
upgrade_phpunit
Jun 7, 2020
Merged

Upgrade phpunit#561
DarkSide666 merged 8 commits intodevelopfrom
upgrade_phpunit

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Apr 15, 2020 •
edited by DarkSide666
Loading

Also fix #575

@mvorisek mvorisek marked this pull request as draft April 15, 2020 18:05
@mvorisek mvorisek closed this Apr 15, 2020
@mvorisek mvorisek reopened this Apr 15, 2020
@mvorisek mvorisek closed this Apr 15, 2020
@mvorisek mvorisek reopened this Apr 15, 2020
@mvorisek mvorisek force-pushed the upgrade_phpunit branch 4 times, most recently from 87e29fd to c86287c Compare April 21, 2020 22:23
@mvorisek
Copy link
Copy Markdown
Member Author

mvorisek commented Apr 21, 2020

Help wanted with the failing tests.

@mvorisek
Copy link
Copy Markdown
Member Author

mvorisek commented May 15, 2020 •
edited
Loading

@DarkSide666 any ETA on this?

@atk4 atk4 deleted a comment from codecov bot Jun 7, 2020
@atk4 atk4 deleted a comment from codecov bot Jun 7, 2020
mvorisek
mvorisek commented Jun 7, 2020
View reviewed changes
mvorisek
mvorisek commented Jun 7, 2020
View reviewed changes
mvorisek
mvorisek commented Jun 7, 2020
View reviewed changes
mvorisek
mvorisek commented Jun 7, 2020
View reviewed changes
mvorisek
mvorisek commented Jun 7, 2020
View reviewed changes
mvorisek
mvorisek commented Jun 7, 2020
View reviewed changes
@atk4 atk4 deleted a comment from codecov bot Jun 7, 2020
@atk4 atk4 deleted a comment from codecov bot Jun 7, 2020
@atk4 atk4 deleted a comment from codecov bot Jun 7, 2020
@DarkSide666 DarkSide666 marked this pull request as ready for review June 7, 2020 22:17
@DarkSide666 DarkSide666 added the RTM label Jun 7, 2020
@DarkSide666 DarkSide666 self-requested a review June 7, 2020 22:28
@DarkSide666 DarkSide666 merged commit 351ca78 into develop Jun 7, 2020
@DarkSide666 DarkSide666 deleted the upgrade_phpunit branch June 7, 2020 22:40
@mvorisek mvorisek mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"mandatory" null validation is not working

2 participants

@mvorisek @DarkSide666