Skip to content

containsOne/Many changes for UI#459

Merged
romaninsh merged 5 commits intodevelopfrom
feature/change-containsone
Sep 9, 2019
Merged

containsOne/Many changes for UI#459
romaninsh merged 5 commits intodevelopfrom
feature/change-containsone

Conversation

@DarkSide666
Copy link
Copy Markdown
Member

@DarkSide666 DarkSide666 commented Sep 5, 2019

fix #451
fix #452
required by atk4/ui#784

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2019

Codecov Report

Merging #459 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #459      +/-   ##
=============================================
- Coverage      86.76%   86.75%   -0.02%     
+ Complexity      1202     1200       -2     
=============================================
  Files             27       27              
  Lines           2645     2642       -3     
=============================================
- Hits            2295     2292       -3     
  Misses           350      350
Impacted Files Coverage Δ Complexity Δ
src/Reference/ContainsMany.php 100% <ø> (ø) 8 <0> (-1) ⬇️
src/Reference/ContainsOne.php 100% <100%> (ø) 11 <0> (-1) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 328a258...5710a62. Read the comment docs.

@romaninsh romaninsh merged commit f2a09f5 into develop Sep 9, 2019
@DarkSide666 DarkSide666 deleted the feature/change-containsone branch September 11, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

containsOne - containsMany with unloaded model containsOne - containsMany system property set to false

2 participants