No implicit IN operator for condition with array value#1092
Merged
No implicit IN operator for condition with array value#1092
Conversation
f292d95 to
ef1fdd2
Compare
ef1fdd2 to
eb9f33f
Compare
eb9f33f to
32d1ae9
Compare
32d1ae9 to
8a9e01a
Compare
e854ec9 to
fe23290
Compare
7c304d9 to
f31146b
Compare
5e1881d to
61b6f36
Compare
DarkSide666
approved these changes
Apr 7, 2025
Member
DarkSide666
left a comment
There was a problem hiding this comment.
LGTM, but it's quite bad BC break because can't be easily fixed by search/replace.
| $key can be Model field name, Field object or Expression object | ||
| $operator can be one of the supported operators >, <, >=, <=, !=, in, not in, like, not like, regexp, not regexp | ||
| $value can be Field object, Expression object, array (interpreted as 'any of the values') or other scalar value | ||
| $value can be Field object, Expression object or any scalar value |
Member
There was a problem hiding this comment.
maybe add words "including array" at the end?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value can be
arraywhich is not rare forjsonDBAL type, thus we cannot check if value is an array nor infer this from SQL expression.