Skip to content

Assert if reference type is the same by default#1091

Merged
mvorisek merged 4 commits intodevelopfrom
strict_ref_type_chack
Feb 9, 2023
Merged

Assert if reference type is the same by default#1091
mvorisek merged 4 commits intodevelopfrom
strict_ref_type_chack

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Feb 9, 2023 •
edited
Loading

marking as BC-break as Reference::checkTheirType needs to be set manually to false if the DBAL type mismatch is intentional

in 99% cases, the exception is right and you want to fix your code

@mvorisek mvorisek force-pushed the strict_ref_type_chack branch from c1d3285 to e9fa739 Compare February 9, 2023 13:37
@mvorisek mvorisek changed the title Assert if reference type is the same Assert if reference type is the same by default Feb 9, 2023
@mvorisek mvorisek force-pushed the strict_ref_type_chack branch from e9fa739 to 9ec3707 Compare February 9, 2023 13:50
@mvorisek mvorisek force-pushed the strict_ref_type_chack branch from 9ec3707 to 65ed644 Compare February 9, 2023 19:42
@mvorisek mvorisek force-pushed the strict_ref_type_chack branch from 65ed644 to af1ea76 Compare February 9, 2023 19:50
@mvorisek mvorisek marked this pull request as ready for review February 9, 2023 20:25
@mvorisek mvorisek force-pushed the strict_ref_type_chack branch from c01e8cd to ac545e8 Compare February 9, 2023 20:51
@mvorisek mvorisek merged commit 856f742 into develop Feb 9, 2023
@mvorisek mvorisek deleted the strict_ref_type_chack branch February 9, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BC-break

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mvorisek