Skip to content

Make SQL Expression & Query classes abstract#1048

Merged
mvorisek merged 14 commits intodevelopfrom
abstract_expr
Aug 14, 2022
Merged

Make SQL Expression & Query classes abstract#1048
mvorisek merged 14 commits intodevelopfrom
abstract_expr

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Aug 14, 2022

Specific driver class is needed to determine correct SQL template and identifier escape character.

Instead of:

new Expression(['connection' => $connection]);
new Query(['connection' => $connection]);

always use

$connection->expr()
$connection->dsql();

Also removing new DBAL 3.4+ support temporary, as many changes are needed like for https://github.com/doctrine/dbal/pull/5513/files#r945271960.

@mvorisek mvorisek force-pushed the abstract_expr branch 2 times, most recently from d71efec to abbc9ef Compare August 14, 2022 11:03
@mvorisek mvorisek changed the title Make SQL Query class abstract Make SQL Expression & Query classes abstract Aug 14, 2022
@mvorisek mvorisek marked this pull request as ready for review August 14, 2022 14:17
@mvorisek mvorisek merged commit d8cd47e into develop Aug 14, 2022
@mvorisek mvorisek deleted the abstract_expr branch August 14, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant