Check model conditions during insert/update/delete#1044
Merged
Conversation
537df65 to
5287bc9
Compare
34f86c4 to
1fbd714
Compare
53c78b7 to
df2e634
Compare
7cb0c26 to
35934c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #866
Originally scope was honored for loading, but ignored for update. This PR makes sure scope is honored for update as well and nothing is updated outside scope. ACL and other security features can now rely on the strict scope behaviour.
Marking as BC breaking as when model's conditions are not met, DB update newly fails.
Soft delete (and simillar) implementations needs to be probably adjusted. Nested model can be used or scope must be "loosen" during operation with archived but normally out-of-scope records.