Fix HasOneSql their field update hook#1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hook was updating our model using SQL query, which was dangerous as all validation/normalization/hooks were skipped. I checked the rest of the atk4/data code, and thankfully, all similar dangerous updates were already migrated to materiazed update.
One of dangerous behaviour was described in atk4/filestore#26.
The hook conditions are still not right and I will fix them in another PR. Thus this PR does not fix the filestore issue, but prevents any related data corruption to happen - if mismatched data are given, an exception is thrown.