Remove WITH/CTE column mapping for model#1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapping duplicated the functionality of
Field::$actual, so we drop the WITH mapping from model completely.Mapping was also used for filtering wanted columns, we drop it as it mutated the source model state and DB query optimizer should be smart enough to prune the unneded columns. Later, we should optimize them away automatically. Alternatively, you can set
Model::$onlyFieldsfor the added CTE model manually.Also, the method was renamed from
Model::addWithtoModel::addCteModeland name/alias is now accepted as the 1st param.