Fix Model::loadXxx() /w limit/offset set#1011
Merged
Conversation
Member
Author
|
@mkrecek234 thank you for the report, the limit offset was also broken, now it should be fixed for both Array/SQL persistences |
c3593c3 to
4612fd7
Compare
Member
Author
|
before merge, I will also emulate support for MSSQL for limit = 0, all other DBs support it |
4612fd7 to
d4b4c1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1010
Array persistence does not need fix, as it wraps the Action
most tests should run /w all persistences but a lot of test redesign is needed