Skip to content

HasOneSql::addField adds field without ->ui['editable'] = false, but it is not saveable #929

@mvorisek

Description

@mvorisek

field added using HasOneSql reference seems to be non-saveable, but currently if added using HasOneSql::addField it is NOT marked with ->ui['editable'] = false thus in the main atk4/filestore demo index.php, the 2 imported fields (actually 4, imported twice) in https://github.com/atk4/filestore/blob/2.4.0/src/Field/File.php#L99 are shown in Form/CRUD and make user fake feel they can be edited. Currently, they are not saved. I have verified this again original atk4/filestore v2.4.0.

I belive ->ui['editable'] = false should be added to the Field seed in HasOneSql::addField or make the field trully saveable from the reference side.

https://github.com/atk4/filestore/blob/develop/docs/images/crud.png historical (from version pre 2.4) screenshot confirms the fields are intended to be non-editable

Current behaviour:

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions