Optimize hook clone performance by mvorisek · Pull Request #371 · atk4/core

mvorisek · 2023-01-21T12:29:30Z

atk4/data entity is created using clone, performance is critical

Time spent in Model::createEntity() is reduced by ~65%.

mvorisek added 4 commits January 21, 2023 01:58

improve hook rebind perf, do not foreach by reference

3ade0c7

makeHookDynamicFx can use static fx

c3b282e

simplify CollectionTrait::_shortenMl dedup

406547d

fix import

7648d33

mvorisek force-pushed the optimize_hook_clone_perf branch from bd68b21 to 9a19c77 Compare January 21, 2023 15:48

rebind to fake this when later rebound anyway to improve GC

867fc8d

mvorisek force-pushed the optimize_hook_clone_perf branch from 9a19c77 to 867fc8d Compare January 21, 2023 16:14

replace rebind on clone in favor of rebind on runtime

7c2f85d

mvorisek force-pushed the optimize_hook_clone_perf branch from 6ea70c6 to 7c2f85d Compare January 21, 2023 16:30

mvorisek added 2 commits January 21, 2023 17:35

optimize GC by storing orig this using weak reference

e90d4f2

add tests

1b06ff6

mvorisek marked this pull request as ready for review January 21, 2023 17:20

microoptimize CollectionTrait::_getFromCollection()

22aa6d2

mvorisek force-pushed the optimize_hook_clone_perf branch from c60f8c4 to 22aa6d2 Compare January 21, 2023 17:48

mvorisek mentioned this pull request Jan 21, 2023

Optimize Model::getIterator() atk4/data#1087

Merged

mvorisek merged commit c6a3588 into develop Jan 21, 2023

mvorisek deleted the optimize_hook_clone_perf branch January 21, 2023 21:47

Provide feedback