Enable phpstan bleading edge and strict rules#362
Merged
Conversation
cd9ece1 to
66a212f
Compare
66a212f to
1e67282
Compare
mvorisek
commented
Aug 26, 2022
| $element->shortName = $name; | ||
| if (TraitUtil::hasTrackableTrait($this) && TraitUtil::hasNameTrait($this) && TraitUtil::hasNameTrait($element)) { | ||
| $element->name = $this->_shorten((string) $this->name, $element->shortName, $element->name); | ||
| $element->name = $this->_shorten($this->name ?: '', $element->shortName, $element->name); // @phpstan-ignore-line |
Member
Author
There was a problem hiding this comment.
(?<!\w)name'?[^,]+false is needed for atk4/ui
bcfa908 to
d43ac63
Compare
0d4e539 to
4aefe38
Compare
4aefe38 to
c1da40b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.