Skip to content

Upgrade phpstan to level 6#318

Merged
mvorisek merged 6 commits intodevelopfrom
phpstan_l6
May 11, 2021
Merged

Upgrade phpstan to level 6#318
mvorisek merged 6 commits intodevelopfrom
phpstan_l6

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented May 5, 2021

rebase after #317

@mvorisek mvorisek force-pushed the phpstan_l6 branch 2 times, most recently from 787398a to 871c4b5 Compare May 6, 2021 09:28
@mvorisek mvorisek marked this pull request as ready for review May 6, 2021 09:29
Copy link
Copy Markdown
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$this->assertSame('form-fields_surname', $surname->name);
$this->assertSame($surname->getOwner(), $m);
$this->assertSame('form-fields_surname', $surnameField->name);
$this->assertSame($m, $surnameField->getOwner());
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussion: phpstan/phpstan#4985

@mvorisek mvorisek force-pushed the phpstan_l6 branch 7 times, most recently from 39da84a to b74b3a0 Compare May 10, 2021 13:36
@mvorisek mvorisek merged commit 4f8db38 into develop May 11, 2021
@mvorisek mvorisek deleted the phpstan_l6 branch May 11, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants