Change visibility of method assertInstanceOfApp#305
Merged
Conversation
|
Like it, had some trouble with other private methods lately. |
mvorisek
requested changes
Dec 28, 2020
| public $unique_hashes = []; | ||
|
|
||
| private function assertInstanceOfApp(object $app): void | ||
| protected function assertInstanceOfApp(object $app): void |
Member
There was a problem hiding this comment.
please try itself before
Collaborator
Author
There was a problem hiding this comment.
i need to override it in class not use it as it is, did you know what are you doing?
If i have to rewrite even traits, user can use another framework, no? I like private but not in traits, too much trouble. machine cycle have a cost.
mvorisek
approved these changes
Dec 28, 2020
Member
mvorisek
left a comment
There was a problem hiding this comment.
well, makes sense that it is not possible to overwrite it easily for framework classes otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow override of method.