Conversation
.github/workflows/bundler.yml
Outdated
| pr_reviewer: "romaninsh" | ||
| pr_assignee: "romaninsh" | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| #- name: pull-request |
There was a problem hiding this comment.
definitely do not comment out old code, simply remove the code
There was a problem hiding this comment.
yes i will cleanup/remove at the end before merging
.github/workflows/bundler.yml
Outdated
| #composer config version --unset | ||
| v=$(echo ${{ github.ref }} | cut -d / -f 4) | ||
| echo "::set-env name=version::$v" | ||
| #echo "::set-env name=version::$v" |
There was a problem hiding this comment.
we use simillar construction in unit testing: https://github.com/atk4/core/blob/develop/.github/workflows/unit-tests.yml#L43
composer.json
Outdated
| } | ||
| ], | ||
| "version": "dev-develop", | ||
| "version-release": "#release_version#", |
There was a problem hiding this comment.
I belive, we should simply replace "dev-develop" directly and drop *-release keys completely, it will simplify the configs and mistakes in all repos
There was a problem hiding this comment.
If replacing atk4 dev-develop is the only thing to replace, then maybe, but idea behind using *-release was that it can be used for any other possible changes which we need when releasing too.
There was a problem hiding this comment.
I am quite sure yes, it is the only thing to replace. We should do that, to simplify that configs and prevent mistakes.
For development, there is require-dev, which should be enought :)
There was a problem hiding this comment.
Agree with Michael and better use jq for editing
.github/workflows/bundler.yml
Outdated
| composer config version --unset | ||
|
|
||
| # set proper version | ||
| #composer config version --unset |
There was a problem hiding this comment.
If there is no reason I do not know, do rely on git tags.
d8ee2e1 to
c935624
Compare
8a13b90 to
0e2a0f2
Compare
09b1ae7 to
20304cd
Compare
20304cd to
423c764
Compare
28d40c7 to
b3dde6c
Compare
b3dde6c to
dda1fdd
Compare
It does all release tasks except the updating "require". This can be done manually/later.
It can be triggered by pushing to "release/*" branch or to a branch suffixed with ".build".
It does then the changes a (force-)pushes the changes to branch with ".gen" suffix.
The release (on the generated branch) should be then checked and if ok, simply tagged with the release version.