Drop PHP v7.3 support and upgrade CS Fixer to v3#278
Conversation
|
@DarkSide666 @georgehristov ok to drop php 7.3 for upcoming 2.4 release? we can already make ˙8.0˙ the latest CI image and develop for php 7.4 and 8.0 versions only. |
|
What advantage we get to deprecate 7.3 at this point? |
|
Mostly syntactic sugar like short closures, with php 8 static return type, ... I do not pursue this PR fow now. Someday we might transpile code for lower php versions. |
|
Well, since 06.12.2020 there are only bugfixes, PHP 7.3: At some point I think we decided to support PHP versions until they run out at php.net, so another year for PHP 7.3. |
|
Do I really remember correctly? We dropped PHP 7.2 before it ran out. However, dropping version support too soon will probably piss off users. |
|
I do not use PHP 7.3 anywhere, I support to drop PHP 7.3 immediatelly, let me know if we should merge :) |
|
I think we should support 7.3 until it runs out completely in php.net. |
|
PHP 7.3 is already phased out from active development, let's remove the support for the upcoming atk4/* v3.0 |
|
Agreeing on this, lets drop it for upcoming versions. This also means that we can use typed properties where possible. |
0f5e244 to
fae5874
Compare
9dc7edf to
b4c6169
Compare
|
looking very good at first glance, thx for the work! |
fb925af to
7769d2f
Compare
fb12ca6 to
e443ebf
Compare
c777b6d to
6bec5c1
Compare
a710d07 to
2ced3aa
Compare
to support using
WeakReferenceand other new features likefn, typed properties