Skip to content

Drop PHP v7.3 support and upgrade CS Fixer to v3#278

Merged
mvorisek merged 5 commits intodevelopfrom
drop_php73
May 11, 2021
Merged

Drop PHP v7.3 support and upgrade CS Fixer to v3#278
mvorisek merged 5 commits intodevelopfrom
drop_php73

Conversation

@mvorisek
Copy link
Copy Markdown
Member

@mvorisek mvorisek commented Oct 1, 2020

to support using WeakReference and other new features like fn, typed properties

@mvorisek mvorisek added waitingForAnotherPR PHP7.4+ Requires PHP 7.4 or higher labels Oct 1, 2020
@mvorisek
Copy link
Copy Markdown
Member Author

@DarkSide666 @georgehristov ok to drop php 7.3 for upcoming 2.4 release?

we can already make ˙8.0˙ the latest CI image and develop for php 7.4 and 8.0 versions only.

@mvorisek mvorisek marked this pull request as ready for review October 17, 2020 10:14
@DarkSide666
Copy link
Copy Markdown
Member

What advantage we get to deprecate 7.3 at this point?
I still use 7.3 quite a lot :)

@mvorisek
Copy link
Copy Markdown
Member Author

mvorisek commented Jan 2, 2021

Mostly syntactic sugar like short closures, with php 8 static return type, ... I do not pursue this PR fow now.

Someday we might transpile code for lower php versions.

@mvorisek mvorisek closed this Jan 2, 2021
@mvorisek mvorisek deleted the drop_php73 branch January 2, 2021 18:58
@PhilippGrashoff
Copy link
Copy Markdown

Well, since 06.12.2020 there are only bugfixes, PHP 7.3:
https://www.php.net/supported-versions.php

At some point I think we decided to support PHP versions until they run out at php.net, so another year for PHP 7.3.

@PhilippGrashoff
Copy link
Copy Markdown

Do I really remember correctly? We dropped PHP 7.2 before it ran out. However, dropping version support too soon will probably piss off users.

@mvorisek
Copy link
Copy Markdown
Member Author

mvorisek commented Jan 2, 2021

I do not use PHP 7.3 anywhere, I support to drop PHP 7.3 immediatelly, let me know if we should merge :)

@DarkSide666
Copy link
Copy Markdown
Member

I think we should support 7.3 until it runs out completely in php.net.
Exception could be in case 7.3 somehow really limits us to continue work on quality toolkit, but if that's just few changes in syntax between 7.3 and 7.4 and no really impressive and useful change, then I see no point to drop support earlier than php.net does that.

@mvorisek mvorisek restored the drop_php73 branch May 4, 2021 10:51
@mvorisek mvorisek reopened this May 4, 2021
@mvorisek
Copy link
Copy Markdown
Member Author

mvorisek commented May 5, 2021

PHP 7.3 is already phased out from active development, let's remove the support for the upcoming atk4/* v3.0

@PhilippGrashoff
Copy link
Copy Markdown

Agreeing on this, lets drop it for upcoming versions. This also means that we can use typed properties where possible.

@mvorisek mvorisek added the RTM label May 5, 2021
@mvorisek mvorisek changed the title Drop php 7.3 version support Drop PHP 7.3 version support May 5, 2021
@mvorisek mvorisek force-pushed the drop_php73 branch 4 times, most recently from 0f5e244 to fae5874 Compare May 6, 2021 07:36
@mvorisek mvorisek removed the RTM label May 6, 2021
@mvorisek mvorisek force-pushed the drop_php73 branch 2 times, most recently from 9dc7edf to b4c6169 Compare May 6, 2021 08:57
@PhilippGrashoff
Copy link
Copy Markdown

looking very good at first glance, thx for the work!

@mvorisek mvorisek force-pushed the drop_php73 branch 2 times, most recently from fb925af to 7769d2f Compare May 11, 2021 09:12
@mvorisek mvorisek changed the title Drop PHP 7.3 version support Drop PHP v7.3 support and upgrade CS Fixer to v3 May 11, 2021
@mvorisek mvorisek force-pushed the drop_php73 branch 2 times, most recently from fb12ca6 to e443ebf Compare May 11, 2021 09:39
@mvorisek mvorisek force-pushed the drop_php73 branch 3 times, most recently from c777b6d to 6bec5c1 Compare May 11, 2021 10:27
@mvorisek mvorisek added the RTM label May 11, 2021
@mvorisek mvorisek force-pushed the drop_php73 branch 2 times, most recently from a710d07 to 2ced3aa Compare May 11, 2021 10:38
@mvorisek mvorisek merged commit 6b92e54 into develop May 11, 2021
@mvorisek mvorisek deleted the drop_php73 branch May 11, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BC-break PHP7.4+ Requires PHP 7.4 or higher RTM

Development

Successfully merging this pull request may close these issues.

4 participants