Skip to content

Release drafter to detect labels#250

Merged
mvorisek merged 1 commit intodevelopfrom
feature/release-drafter-should-detect-labels
Apr 10, 2021
Merged

Release drafter to detect labels#250
mvorisek merged 1 commit intodevelopfrom
feature/release-drafter-should-detect-labels

Conversation

@romaninsh
Copy link
Copy Markdown
Member

- title: "Major Features"
labels:
- "MAJOR"
- title: "Documentation enhancements"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this help somehow?

It will be actually good if we can exclude small-fix labels (like for typos - documenting these PRs is unwanted) and maybe doc updates too

@mvorisek
Copy link
Copy Markdown
Member

mvorisek commented Jul 2, 2020

This PR is not good, as if both BC-break and MAJOR labels are presented, the changes are duplicated under both sections.

Breaking changes should not be duplicated in any other section. Not sure if this is possible now.

We should exclude PRs for small fix labels, it should be possible - https://github.com/release-drafter/release-drafter#exclude-pull-requests

So maybe we can exlude all irelevant PRs instead and do not add major section at all.

@mvorisek mvorisek marked this pull request as draft July 2, 2020 09:20
@mvorisek mvorisek marked this pull request as ready for review April 10, 2021 10:21
Copy link
Copy Markdown
Member

@mvorisek mvorisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency LGTM

@mvorisek mvorisek merged commit b6f24d6 into develop Apr 10, 2021
@mvorisek mvorisek deleted the feature/release-drafter-should-detect-labels branch April 10, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants