Fix missing default/nil values related to object_of and array_of in bundle extensions#432
Merged
Blacksmoke16 merged 1 commit intomasterfrom Jul 29, 2024
Merged
Fix missing default/nil values related to object_of and array_of in bundle extensions#432Blacksmoke16 merged 1 commit intomasterfrom
object_of and array_of in bundle extensions#432Blacksmoke16 merged 1 commit intomasterfrom
Conversation
object_of and array_of in bundle extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Noticed this while working on #431. It seems the logic that was populating unprovided values, either default or
nil, to the named tuple ended up inValidateArguments. This made it so that the values appeared correct when printing the finalCONFIGvalue, but was not done in time to be present at the time extensions are executed.Changelog
object_oforarray_ofin bundle extensions