Relax ACON::Application version to accept any String
#419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default to `UNKNOWN` as we do not want to assume semver anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ACON::Applicationallows providing a version representing the version of the application. This was previously needlessly strict in requiring a semver string. This PR relaxes this to allow any String, enabling calver, or whatever other format is desired.This PR also makes the default version
UNKNOWN, which is more accurate as we don't want to assume the versioning pattern of the application. This maybe will also encourage people to properly version it.Changelog
ACON::Application#versiongetter and ivar aStringUNKNOWNas we do not want to assume semver anymoreframeworkintegration to not try to still pass aSemanticVersion