-
-
Notifications
You must be signed in to change notification settings - Fork 19
Console tab-completion #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some bugs
More bug squashing + specs
add specs
Handle logging suggestions to debug file
|
Wow! Incredible! |
Member
Author
|
@paulocoghi Is still some work to do (mainly adding the other shells and augmenting existing commands), but feel free to try it out and let me know if you have any issues/suggestions. |
|
I will try it and let you know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements command tab completion by leveraging the shell's built in completion features. Currently only
bashis supported, butfishandzshcan/will be added in another PR. Command and option names are supported out of the box. Option/argument values can be defined by using the newsuggested_valuesoption when adding arguments/options which accepts either anEnumerable(String)or a block that should return anArray(String)if additional filtering is desired. The#completemethod may also be overridden for more complex usages.This functionality does require sourcing/placing a generated file in a location where you shell is able to read it. E.g. sourced within
~/.bashrcor placed within/etc/bash_completion.d/. This is a one-time setup, so not too big of a deal.This can be done via the
completioncommand that is bundled in with all console applications. E.g../console completion > completion.sh. Run./console help completionformore information.The name of the binary used to generate the script is important. In this case,
completion.shwould handle auto completion for a binary calledconsole, but not one called something else.The completion script also is required to run with real binaries, not via like
crystal run src/console.cr -- completion.assert_command_is_successfulto the*TestertypesResolves #293