Merged
Conversation
[ci skip]
for The tuple interface for _InventoryItem objects is deprecated
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 89.62% 89.49% -0.13%
==========================================
Files 31 31
Lines 1253 1257 +4
==========================================
+ Hits 1123 1125 +2
- Misses 130 132 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bsipocz
approved these changes
Dec 12, 2025
Member
bsipocz
left a comment
There was a problem hiding this comment.
The fix works for astroquery if the version check is changed. So I go ahead and add the changes and merge this now, and maybe also do a bugfix release.
Fixing version checks, the warning came in v9.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #230
This would need downstream testing first. There is no easy way to do this via RTD, so probably have to build some downstream docs manually when I get the chance, or if downstream devs want to step in.