MAINT: dropping support for python 3.8#213
Merged
pllim merged 4 commits intoastropy:mainfrom Jun 14, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 31 31
Lines 1252 1252
=======================================
Hits 1123 1123
Misses 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Some weird errors coming from the oldestdeps (sphinx 4.0) build that we haven't seen with python3.8. I'm very much inclined to just work it around with bumping the minimum sphinx to 5.0, too. It was released in 2022, so I feel it's still old enough. |
40963fe to
03d9ed4
Compare
pllim
reviewed
Jun 13, 2025
Member
pllim
left a comment
There was a problem hiding this comment.
Thanks! Do we still need sphinx53?
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.