Skip to content

MAINT: dropping support for python 3.8#213

Merged
pllim merged 4 commits intoastropy:mainfrom
bsipocz:MAINT_dropping_py38
Jun 14, 2025
Merged

MAINT: dropping support for python 3.8#213
pllim merged 4 commits intoastropy:mainfrom
bsipocz:MAINT_dropping_py38

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Jun 13, 2025

No description provided.

@bsipocz bsipocz added this to the v0.21.0 milestone Jun 13, 2025
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (ce2297b) to head (8151b2e).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          31       31           
  Lines        1252     1252           
=======================================
  Hits         1123     1123           
  Misses        129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz
Copy link
Member Author

bsipocz commented Jun 13, 2025

Some weird errors coming from the oldestdeps (sphinx 4.0) build that we haven't seen with python3.8.

Sphinx version error:
The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.

I'm very much inclined to just work it around with bumping the minimum sphinx to 5.0, too. It was released in 2022, so I feel it's still old enough.

@bsipocz bsipocz force-pushed the MAINT_dropping_py38 branch from 40963fe to 03d9ed4 Compare June 13, 2025 21:31
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do we still need sphinx53?

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit dceb4e5 into astropy:main Jun 14, 2025
20 checks passed
@bsipocz bsipocz deleted the MAINT_dropping_py38 branch June 14, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants