Skip to content

MAINT: minor updates#211

Merged
pllim merged 2 commits intoastropy:mainfrom
bsipocz:MAINT_minor_cleanup
Jun 14, 2025
Merged

MAINT: minor updates#211
pllim merged 2 commits intoastropy:mainfrom
bsipocz:MAINT_minor_cleanup

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Jun 13, 2025

Running pyupgrade to cleanup a little bit. While these all look good to me I didn't want to block the release with this cleanup.

@bsipocz bsipocz added this to the v.0.21.0 milestone Jun 13, 2025
@bsipocz bsipocz requested a review from pllim June 13, 2025 00:02
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (ec44299) to head (208efd0).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
sphinx_automodapi/automodapi.py 50.00% 1 Missing ⚠️
sphinx_automodapi/automodsumm.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          31       31           
  Lines        1252     1252           
=======================================
  Hits         1123     1123           
  Misses        129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

if current_module and \
not name.startswith(current_module + '.'):
name = "%s.%s" % (current_module, name)
name = "{}.{}".format(current_module, name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No f-string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, indeed.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit dd19193 into astropy:main Jun 14, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants