Merged
Conversation
Member
|
Thanks! I'm going ahead and merge this, I'm afraid the failing job is likely highlights some incompetency with sphinx 6.2 :( |
Member
|
I've pushed more CI related changes to this PR, IMO monthly crons are useless, it doesn't hurt to have them weekly instead. And for low-traffic repos like this, canceling jobs on failure is more annoying than useful, too. |
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 27 27
Lines 1141 1141
=======================================
Hits 1025 1025
Misses 116 116 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
See #164 as a follow-up issue for the sphinx dev problem, otherwise this PR fixes problems, so I go ahead and merge it now. |
bsipocz
approved these changes
Apr 13, 2023
Member
|
Thanks, all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the codecov PyPI package from the dependencies. The workflow is already using the codecov uploader action, so this should not be needed, unless coverage needs to uploaded from elsewhere?