Skip to content

FEAT: Use pydata-sphinx-theme in conf/v2.py#59

Merged
pllim merged 7 commits into
astropy:mainfrom
pllim:pydata-sphinx-theme
Jun 6, 2023
Merged

FEAT: Use pydata-sphinx-theme in conf/v2.py#59
pllim merged 7 commits into
astropy:mainfrom
pllim:pydata-sphinx-theme

Conversation

@pllim

@pllim pllim commented May 24, 2023

Copy link
Copy Markdown
Member

Switch from astropy-sphinx-theme to pydata-sphinx-theme.

The changes here are plucked from astropy/astropy#14477 (thanks, @saimn !)

To see real changes between v1 and v2, run this locally:

diff sphinx_astropy/conf/v2.py sphinx_astropy/conf/v1.py

Used in:

@pllim pllim force-pushed the pydata-sphinx-theme branch from 94d2541 to 238bdab Compare May 24, 2023 18:56
@pllim

pllim commented May 24, 2023

Copy link
Copy Markdown
Member Author

Close/reopen to trigger CI. It was disabled due to lack of activity.

@pllim pllim closed this May 24, 2023
@pllim pllim reopened this May 24, 2023
@pllim pllim force-pushed the pydata-sphinx-theme branch from fa4d096 to abffa6c Compare May 24, 2023 19:19
@pllim pllim force-pushed the pydata-sphinx-theme branch from 284ee0d to f78da2e Compare May 25, 2023 06:14
@pllim pllim marked this pull request as ready for review May 25, 2023 19:23
@pllim pllim requested review from eteq and saimn May 25, 2023 19:23
@pllim

pllim commented May 25, 2023

Copy link
Copy Markdown
Member Author

This should be now fully backward compatible.

:shipit:

Comment thread sphinx_astropy/conf/v2.py Outdated
@hamogu

hamogu commented Jun 2, 2023

Copy link
Copy Markdown
Member

@eteq You are one of the people who might have feelings on this... We discussed this at the dev telecon and there we all thought this could progress and be merged.

pllim and others added 7 commits June 2, 2023 15:16
and moved custom.css stuff downstream.

Customize copy button to not copy code
prompt or output.

Misc v2 fixes.
by not introducing breaking change to the status quo.
Also remove deprecated function from v2.
because it is repetitive
@pllim pllim force-pushed the pydata-sphinx-theme branch from 13d0db4 to 3cc8b4f Compare June 2, 2023 19:18

@saimn saimn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pllim pllim merged commit 31ea12f into astropy:main Jun 6, 2023
@pllim pllim deleted the pydata-sphinx-theme branch June 6, 2023 17:55
@pllim

pllim commented Jun 6, 2023

Copy link
Copy Markdown
Member Author

Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants