Use simpler checks for invalid values#155
Merged
ojustino merged 4 commits intoastropy:mainfrom Dec 5, 2022
Merged
Conversation
kecnry
reviewed
Dec 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 75.77% 75.77%
=======================================
Files 9 9
Lines 706 706
=======================================
Hits 535 535
Misses 171 171
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kecnry
approved these changes
Dec 5, 2022
Member
|
I took the liberty to fix change log directly in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to findings from #153, I've changed most uses of
np.ma.mask_invalid()to~np.isfinite()since we only sought a mask instead of an entire masked array object most times it was used. We do still want a masked array as the final result ofFitTrace, so it remains in use there.These changes should help tests pass with numpy v1.24.0rc1. Would close #153.