Move astropy.samp to pyvo.astropy_samp#527
Conversation
|
@astropy/coordinators -- how is Mridul not yet part of the org? Please resolve it, so we don't need to approve CI on his PRs. |
|
Ooops. I have invited @MridulS to |
|
Not sure what is going on but @tomdonaldson and/or @astrofrog would be the best person to advice for this effort.
|
|
It looks like the naming convention for the modules here is Also I cannot run the tests from this branch. It looks like they are disabled since this astropy/astropy@7c7e488 ? |
|
On Mon, Apr 15, 2024 at 02:07:09AM -0700, Manon Marchand wrote:
It looks like the naming convention for the modules here is
`pyvo.group.standard` or `pyvo.standard` which would give
`pyvo.app.samp` or `pyvo.samp`. Which one do you all think is best?
I'm all for short paths, so it would be pyvo.samp for me.
There is a bit of trouble there because pyvo.samp already contains a
few convenience wrappers, but from the top of my head I don't think
there are name clashes between the old astropy samp namespace and the
old pyvo.samp.
|
Feel free to disable them in your branch here. p.s. Though by now I think Mridul's contract is done and he has moved on, so maybe a |
|
Hello! Asking here as it seems like it would notify the relevant people. I'd like to make some contributions to the astropy / pyvo SAMP implementation, mainly fixing some of the 'gotchas' like the default behaviour around callback exception handling or the non-blocking behaviour of a client listening for events. Since this branch looks like it's stale, can I try to take this over and help move |
|
It is not up to me but I would be happy if someone can take this over and push it over the finish line. Likely you have to start fresh because there are new changes to |
To fix #155 and another take on #239