Skip to content

DEP: update lagging dependencies to match astropy dev's test requirements#72

Closed
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros:dep/update-dependencies
Closed

DEP: update lagging dependencies to match astropy dev's test requirements#72
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros:dep/update-dependencies

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

Since I'm juggling with test dependencies these days, I thought I would upstream a couple of my findings.
This does 2 things:

  • bump dependencies to match astropy's current requirements (some of which are not explicitly declared anywhere yet, but are in PRs)
  • add comments for dependencies of this packages that are not currently used for astropy's own needs.

I don't know exactly what the scope of this metapackage entails. Should these unused dependencies be removed entirely, even at the risk of breaking any other consumers, or should they be left in place for backwards compat ?

@eerovaher
Copy link
Copy Markdown
Member

When I tried to update dependency requirements in #49 I was told that if astropy needs to be more restrictive with its dependencies then it needs to specify that in its own configuration, and astropy requirements are not sufficient motivation for updating anything here.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

Thanks for the additional context. This seems like good grounds to justify ridding astropy of pytest-asttopy entirely.

Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can bump versions here, but certainly not this aggressively; and certainly no comments about what astropy has and doesn't have as it doesn't matter for this package and its other users.

@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Nov 12, 2025

And if we dump any dependencies, then is should be hypothesis rather than the other small plugins that astropy may not use (though filter-subpackage is in fact quite useful for astropy itself)

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

neutrinoceros commented Nov 12, 2025

Ok then I don't think there's much point doing it at all. Thanks anyway

@neutrinoceros neutrinoceros deleted the dep/update-dependencies branch November 12, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants