Skip to content

Simplify package setup#914

Merged
larrybradley merged 14 commits intoastropy:masterfrom
larrybradley:update-setup
Aug 9, 2019
Merged

Simplify package setup#914
larrybradley merged 14 commits intoastropy:masterfrom
larrybradley:update-setup

Conversation

@larrybradley
Copy link
Member

No description provided.

@larrybradley larrybradley changed the title Update setup Simplify package setup Aug 7, 2019
@larrybradley larrybradley added this to the 0.7 milestone Aug 7, 2019
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good but I would not recommend adding the pyproject.toml file until #915.

@larrybradley
Copy link
Member Author

@astrofrog, @bsipocz: The python 3.5, numpy 1.13, astropy LTS job is failing with seg faults trying to compile the cython files. Any idea what's going on there?

https://travis-ci.org/astropy/photutils/jobs/568857136#L3062

@bsipocz
Copy link
Member

bsipocz commented Aug 8, 2019

weird, as with a quick glance I don't see any version number differences with the installed dependencies.

@astrofrog
Copy link
Member

Very strange, I'll try on my Linux desktop shortly.

@larrybradley
Copy link
Member Author

@astrofrog Did you find anything? I'm going to start digging into this. I'm planning to release 0.7 today (🤞) and I'd like to include this if possible.

@astrofrog
Copy link
Member

@larrybradley - testing now

@larrybradley
Copy link
Member Author

Many thanks! I haven't started on this yet.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured out the issue! See below

@larrybradley
Copy link
Member Author

@astrofrog This is ready for final review.

@larrybradley
Copy link
Member Author

I've implemented the requested changes and the test pass now. The astropy-dev test failure is unrelated. Thanks again, @astrofrog.

@larrybradley larrybradley merged commit a3d2b75 into astropy:master Aug 9, 2019
@larrybradley larrybradley deleted the update-setup branch August 9, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants