Fix Sphinx warnings about duplicate objects#1306
Merged
larrybradley merged 2 commits intoastropy:mainfrom Mar 12, 2022
Merged
Conversation
|
Hello @larrybradley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-03-12 00:42:36 UTC |
2a87d06 to
2fb0a4b
Compare
2fb0a4b to
fa2ecdc
Compare
This was referenced Mar 24, 2022
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with
Sphinx 4.0, when building the docs warnings were issued about duplicate objects for thepsf.matchingfunctions.psf.__init__is importing all frompsf.matching, and I think Sphinx is getting confused by seeing these tools both aspsf.<tool>andpsf.matching.<tool>.I don't know if this is the best solution, but explicitly removing the
psf.matchingtools frompsf.__all__seems to solve the issue.Closes #1238