Conversation
…into astrometry_net
|
@fred3m - could you link to the WIP branch? |
astroquery/astrometry_net/core.py
Outdated
There was a problem hiding this comment.
Could we call this AstrometryNetClass instead?
|
I have talked to the Astropy developers and it seems that automatically writing the API in the configuration file would not be a good idea. There are several reasons for this — the most convincing of them probably being that this could be very confusing for users, who may found that another library has modified their configuration file by calling our code. Would using |
|
Ok, I think this should be good to go. Try testing it and let me know if it works. The only thing that will need to be changed is that they use a print function in a way I've never seen to build their data packet, and it won't be compatible with Python 3 (I had to comment out the future import). |
astroquery/astrometry_net/core.py
Outdated
There was a problem hiding this comment.
I think you can use self._fp.write instead of print
|
Does this code still work? Is there any remaining issues that prevent it from being merged? |
|
Actually, it probably can be merged... it would be nice to have some remote tests in place so we can be sure, but really I just lost track of it. |
There was a problem hiding this comment.
this header needs to be filled out
|
Sorry, I let this slip through the cracks too. I haven't taken a look at this in a while so it may take me a few days to make the changes. |
|
@fred3m @crawfordsm Just a ping reminding you that this is open and nearly done |
|
Thanks for the reminder. I've been neck deep in job applications and my thesis lately but one weekend when I need a break I'll try and pound this out. Sorry that this is taking so long... |
|
Thanks Fred and good luck with everything! |
ab0c591 to
712c326
Compare
|
superceded by #1163 |
Working on this with Victor Terron