EXP: check if upstream patch in astropy fixes devdeps#2931
Closed
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
Closed
EXP: check if upstream patch in astropy fixes devdeps#2931neutrinoceros wants to merge 1 commit intoastropy:mainfrom
neutrinoceros wants to merge 1 commit intoastropy:mainfrom
Conversation
1 task
Contributor
Author
|
ah, of course my branch needs to be built from source, and by default this happens in isolation against numpy 1.x, which then crashes pytest on collection... |
Contributor
Author
|
I couldn't make it work with tox but I was able to run tests locally with every dependency compiled against numpy 2 and, compared with the reference run, I got rid of all errors ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think astropy/astropy#15948 should resolve errors currently seen here in devdeps. Let's put that to the test.