Gallery updates#229
Closed
eteq wants to merge 4 commits into
Closed
Conversation
Contributor
|
There are still a boatload of unresolved warnings that I've never had the time to go through and debug. The docs build, but there may be funny issues here and there. I fixed example 3 (I think it was just incomplete... must have been a work in progress, then I got distracted...) - could you rebase? |
Member
Author
|
@keflavich - where did you fix example 3? master still looks the same to me... Anyway, that's good, though. It would be better if you issued a PR against my branch (https://github.com/eteq/astroquery/tree/gallery-updates) instead of astropy/astroquery. Or just point me to where you have the commit and I can merge it myself. Then there's no need for anyone to rebase. |
Contributor
|
I rebased & merged this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an entry to the example gallery, and fixes it up to be a bit more consistent.
I tried to build this locally, but I got a ton of sphinx warnings of all sorts, even before this PR. @keflavich, do you see the same thing, or do the docs build for you without complaint?
Note that I also elminated the (old) Exmaple 3, because it didn't work. Let me know if it is actually supposed to work, @keflavich, and if so, how it might be fixed.