New truths for visualization.wcsaxes#116
Merged
pllim merged 1 commit intoastropy:gh-pagesfrom Aug 25, 2021
Merged
Conversation
Member
Author
|
#yolo |
12 tasks
Member
|
Just to check, have you checked all the images to make sure there are no significant differences? @Cadair - any idea why there were differences in the first place? I thought you said that with the matplotlib wheels the images should then be reproducible? |
Member
Author
I see some axis labels jitter here and there. They don't seem significant to me but I cannot speak for everyone. Do I care if the rendered arcsec symbol jumps a little? Not really. |
Member
Author
|
You can probably still look at artifacts at https://app.circleci.com/pipelines/github/astropy/astropy?branch=pull%2F12032 and see for yourselves before they get deleted by CircleCI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to update "truths" for
astropy.visualizationtests for astropy/astropy#12032. I have tested that they work.