Skip to content

TST: Temporarily pin numpy<1.18 for Windows#9878

Merged
bsipocz merged 2 commits intoastropy:masterfrom
pllim:pin-win-numpy
Jan 21, 2020
Merged

TST: Temporarily pin numpy<1.18 for Windows#9878
bsipocz merged 2 commits intoastropy:masterfrom
pllim:pin-win-numpy

Conversation

@pllim
Copy link
Member

@pllim pllim commented Jan 21, 2020

This is a stop-gap solution for #9871 . This should be reverted when that issue is resolved upstream.

@bsipocz
Copy link
Member

bsipocz commented Jan 21, 2020

Cancelled all but windows build.

normally I would prefer the numpy versions to be explicit, but since this is a temporarily workaround, <1.18 should be fine.

@bsipocz
Copy link
Member

bsipocz commented Jan 21, 2020

apparently the < is not OK, so I go ahead and make the changes to get this in asap.

@bsipocz
Copy link
Member

bsipocz commented Jan 21, 2020

(all, but the windows build is cancelled, merge away once that's passing)

@bsipocz bsipocz added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Jan 21, 2020
@astrofrog
Copy link
Member

astrofrog commented Jan 21, 2020

This CI issue will actually be fixed when #9726 is merged (since Numpy won't be installed with conda anymore), so can we hold off maybe so as not to create conflicts? I think @eteq was planning to have one last look at that PR before merging.

@pllim pllim removed the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Jan 21, 2020
@astrofrog
Copy link
Member

Just to be clear I'd still advocate keeping this open though in case #9726 gets delayed beyond a couple of days.

@bsipocz
Copy link
Member

bsipocz commented Jan 21, 2020

@astrofrog - I would rather merge this away, normalizing having failing CI sets a bad precedent (it's already too bad that we had expected failures for a couple of weeks now with the other jobs), and this conflict would be a rather trivial one for #9726 to resolve (besides this may need to be backported, depending on how long it takes to get the upstream fix).

@astrofrog
Copy link
Member

Ok sounds good - let's do it!

@bsipocz bsipocz merged commit 6ef55d8 into astropy:master Jan 21, 2020
@bsipocz
Copy link
Member

bsipocz commented Jan 21, 2020

Ok sounds good - let's do it!

Thanks @astrofrog!

@pllim pllim deleted the pin-win-numpy branch January 21, 2020 19:57
@mhvk
Copy link
Contributor

mhvk commented Jan 21, 2020

Thanks all, I think this is an excellent solution, especially as the comment in .travis.yml makes very clear what we're doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants