Use environment variables to select system libraries#9730
Use environment variables to select system libraries#9730astrofrog merged 3 commits intoastropy:masterfrom
Conversation
mhvk
left a comment
There was a problem hiding this comment.
This looks all OK except that I would really like those very long lines to be split... But that's nitpicky enough that I'll approve.
|
@mhvk - I split the lines in my latest commit |
Previously, the --use-system-... command-line options required patching the setup.py commands, and these were also not easy to set when doing pip installs. The environment variable approach no longer requires patching the commands, and works regardless of whether pip or setup.py is used.
8e10279 to
c0ccadf
Compare
50a2873 to
05cacd1
Compare
|
Since @mhvk has already approved this, @olebole is happy with this approach for Debian packaging, and given that people approved APE 17 which describes this approach, in the interest of finishing up #9726 I am going to go ahead and merge this. If absolutely needed, we can consider adding back command-line flags to |
|
Is this something that needs a "What's new"? |
|
@MSeifert04 - it may only be relevant for distribution maintainers, so it might make more sense to just ping them all directly? |
|
Not sure, that's why I asked. Having some sort of "if you had x before, now you need to do y" in a whatsnew could help those who had the need or urge to build against system libraries - but if that's something that only distribution maintainers used then pinging them directly makes more sense. |
|
I'll label in just in case, and we can decide later :) |
|
I think a what's-new is needed, but would do it as part of the larger astropy-helpers removal (i.e., a what's new that includes a checklist of related changes) |
|
Wait a minute... Didn't @astrofrog insist that what's new entry should be added as part of the PR instead of waiting till release time? |
This is a self-contained subset of changes related to the APE A roadmap for package infrastructure without astropy-helpers. This PR as-is is ready for review, and does not actually require removing astropy-helpers to work, though I think we should maybe wait until Tuesday to merge since that's when we'll be discussing the APE in Socorro.
Previously, the
--use-system-...command-line options required patching the setup.py commands, and these were also not easy to set when doing pip installs. The environment variable approach no longer requires patching the commands, and works regardless of whether pip or setup.py is used. This approach is described in the APE.I checked with @olebole who confirmed this approach would not pose issues for Debian packaging.