Quantity __array_function__ overrides for np.linalg #9494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a bug in construction of a diagonal array with np.diag.
11 tasks
adrn
approved these changes
Oct 29, 2019
adrn
reviewed
Oct 29, 2019
Member
adrn
left a comment
There was a problem hiding this comment.
Ah, actually, I now wonder if this should get a changelog entry, or a note in the documentation?
Contributor
Author
|
@adrn - this will be part of the general |
Member
|
Got it. Given that, I'm happy with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to complete coverage in the nick of time, here's overrides and tests for np.linalg.
fixes #8622
Also adds two further tests for
np.fftroutines that are not wrapped (and always worked well), and fixes a bug innp.diag