Skip to content

MNT: Deprecate utils.timer #9038

Merged
bsipocz merged 1 commit intoastropy:masterfrom
pllim:depre-timer
Jul 26, 2019
Merged

MNT: Deprecate utils.timer #9038
bsipocz merged 1 commit intoastropy:masterfrom
pllim:depre-timer

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Jul 22, 2019 •
edited
Loading

Fix #8898

Companion PR for astropy/astroquery#1508

TODO

  • Add change log
  • Actually deprecate stuff
  • Update tests affected by deprecation warning

@pllim pllim added this to the v4.0 milestone Jul 22, 2019
@pllim pllim mentioned this pull request Jul 22, 2019
Closed
3 tasks
@pllim pllim marked this pull request as ready for review July 25, 2019 19:15
@pllim pllim changed the title [WIP] Deprecate utils.timer MNT: Deprecate utils.timer Jul 25, 2019
@pllim pllim requested review from astrofrog, bsipocz and saimn July 25, 2019 19:27
@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Jul 25, 2019

The only thing we need to be sure to do is to release astroquery 0.4 before astropy 4.0. But that's totally reasonable, so I think this is good to be merged now.

@pllim
Copy link
Copy Markdown
Member Author

pllim commented Jul 25, 2019

Thanks for the review, @bsipocz !

I wouldn't worry too much about the release order, given that recommended astroquery installation is to install using --pre flag anyway. In the worst case scenario with astropy 4.0 being released first and user is using astroquery<0.4, they see a warning.

@pllim pllim added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Jul 25, 2019
@bsipocz bsipocz merged commit 94cdb1b into astropy:master Jul 26, 2019
@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Jul 26, 2019

Thanks @pllim!

@pllim pllim deleted the depre-timer branch July 26, 2019 14:45
@pllim pllim mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz approved these changes

@saimn saimn Awaiting requested review from saimn

@astrofrog astrofrog Awaiting requested review from astrofrog

Assignees

No one assigned

Labels

Refactoring utils zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now.

Projects

None yet

Milestone

v4.0

Development

Successfully merging this pull request may close these issues.

MNT: Move utils.timer to astroquery

2 participants

@pllim @bsipocz