Hi there @bsipocz 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I see this is a work in progress pull request. I'll report back on the checks once the PR is ready for review.

If there are any issues with this message, please report them here.

Is it just me, or Travis CI not showing up?

the yaml file is messed up atm, I'm trying to multitask fix it. Also note that this points to my fork ci-helpers, so do not merge in any case.

this is failing horridly due to all kind of unrelated numpy issues, but if you into the travis details this build is the only relevant here:

https://travis-ci.org/astropy/astropy/jobs/445288366

Can I have feedbacks on this (mainly the infrastructure, do we want to have other ways to specify what not to try to import, etc.), so we can move forward and see whether there is any modules that need some extra fixing before the RC.

https://travis-ci.org/astropy/astropy/builds/449134809 reported ImportError on 18 modules but it is unclear why. Some of those don't look like they have pytest dependencies...?

Looks like the error messages are collected but not reported:

https://github.com/bsipocz/ci-helpers/blob/e89474b49305123ebdddb994d45aeeb65b8619dd/utils/import_submodules.py#L61

@pllim - I tried the other way, but there are so many that it seemed a bit useless to print all as an error, but it's not at all a preference, I'm happy to change the script.

Also, I'm not exactly sure why numpy is picked up from the compatibility module, the stuff it reports is not even in there.

I think the recursive import is too recursive? For example, maybe when the module does from numpy import ..., it goes into numpy and so on.

p.s. Can probably exclude things like setup_package.py from import test. Not sure why wcsaxes failed though.

Hi humans 👋 - this pull request hasn't had any new commits for approximately 5 months. I plan to close this in a month if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

OK, so I suppose this now needs to be added to one of the pipelines, e.g. on circleCI. What do you think @astrofrog?

(as well as fix the remaining failures)

I would add this to Travis unless there is a good reason to add it to CircleCI. Instead of using wget, could you use urlretrieve in a python -c call so that it works on all platforms?

My only reason for circleCI was that this ideally could live in a pipeline. First run this, then install the test dependencies without the need to rebuild astropy.

I can certainly factor out wget, but didn't think we want to run it in other platforms. Arguably the script would work, but I haven't tested it on windows.

So coming back to this, I wonder whether actually having #10358 is sufficient? Essentially the doctest collection triggers an import of every module and will complain if an import doesn't work, and also is able to take into account special cases as specified in the setup.cfg. So maybe we have accidentally solved this issue and don't need an additional set of tests?

Hi humans 👋 - this pull request hasn't had any new commits for approximately 5 months. I plan to close this in a month if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.