Remove arguments for super (trivial cases)#6613
Conversation
|
Hi there @MSeifert04 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here |
saimn
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking this one @MSeifert04 !
|
Looks good to me too. Thanks for the cleanup! |
|
can this be merged? |
|
While it looks good, I'm running through the diff one more time, and then will hit the button. |
bsipocz
left a comment
There was a problem hiding this comment.
Everything looks right to me.
|
Thanks @MSeifert04 for this cleanup! |
This removes the arguments for
superfor the trivial cases (first argument the class and the second argument the argument to be bound).There are still dozens of places where removing the arguments could change the behavior. I didn't want to touch those, most looked like copy&paste mistakes but some seemed genuine. Probably better to do that later on a per-subpackage basis.