#6182 Modified the behaviour of realize_frame so it changes the representation attribute of the frame#6208
#6182 Modified the behaviour of realize_frame so it changes the representation attribute of the frame#6208Cadair wants to merge 1 commit intoastropy:masterfrom
representation attribute of the frame#6208Conversation
|
An alternative fix to this might be to revert the changes to |
|
@eteq You broke it ;) |
|
I am milestoning this to v2 since it won't be "affect dev" anymore after release. @Cadair , do you plan to address the test failures? |
|
@pllim There needs to be another solution really, but I don't understand enough of the reasons behind the change in the first place. |
|
@Cadair Just so I understand: the SunPy code is needed because you'd like to be able to enforce that the representation becomes a |
|
Yes, and for another frame we use a similar bit of logic to fill the radius coordinate with a default value. |
|
As this is in part a problem from me urging @eteq to use |
SunPy sets the representation of the frame inside the
__init__for the frame to work around Longitude wrapping. #6182 changed the behaviour ofrealize_frameso that it now explicitly set's the representation of the new frame to that of the old frame, which means we can't change the representation of the frame in the__init__in the correct way.Offending line in SunPy: https://github.com/sunpy/sunpy/blob/master/sunpy/coordinates/frames.py#L338
Offending commit in Astropy: 1729467
This fix is a bit facetious in that I am sure it will break something, I am open to suggestions for an actual fix to this problem!