Add kessel_run unit#5927
Conversation
|
Are you still dreaming? Where is your totem? |
mwcraig
left a comment
There was a problem hiding this comment.
I'm a day late, but I think the equivalencies added in this PR are all wrong. As the doc for the proposed unit and the changelog entry clearly state, kessel_run is a time unit.
OTOH, it appears according to authoritative sources that it may never have been intended as a time unit, instead representing a navigational shortcut (or perhaps even an empty boast).
|
Also: Shouldn't it be an imperial unit? |
|
@mwcraig , yes, all good points. I had a hard time figuring out how to make it a time unit without violating the law of physics. @MSeifert04 , never! If you want it to be in a proper module, perhaps Anyway, due to the confusing definitions (even more confusing than |
|
@pllim - Ohh, I just had this brilliant special day idea of moving u.emu to the bird units :) |
|
@bsipocz , save that for next year! Although it should really be |
Add new unit for Kessel Run.