Quantity numpy ufunc additions: ufunc.at, reduce, reduceat, accumulate, outer#2948
Closed
mhvk wants to merge 5 commits intoastropy:masterfrom
Closed
Quantity numpy ufunc additions: ufunc.at, reduce, reduceat, accumulate, outer#2948mhvk wants to merge 5 commits intoastropy:masterfrom
mhvk wants to merge 5 commits intoastropy:masterfrom
Conversation
69f42ce to
fc14c4a
Compare
Contributor
|
I think this is fine, but it's sort of a documentation issue -- people may write code with Numpy 1.10 and be surprised when it doesn't work with earlier versions. Don't know how best to communicate that, though. |
Contributor
Author
fc14c4a to
b773713
Compare
Contributor
Author
|
Rebased to use the new converters instead of scales. Of course, still needs #2583 to be merged first. |
4 tasks
Contributor
Author
|
Closing since this is now part of #2583 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows on the introdoction of
__numpy_ufunc__in #2583 (so only look at last commit), adding support toQuantityfor ufunc methods [1]:ufunc.at,reduce,reduceat,accumulate, andouter. It think it will be useful, though one problem is that I do not know how to support this without__numpy_ufunc__; thus, it will only work in numpy >=1.10.[1] http://docs.scipy.org/doc/numpy/reference/ufuncs.html#methods