New Sphinx with extra values to unpack#2914
Closed
dpshelio wants to merge 1 commit into
Closed
Conversation
This was referenced Sep 2, 2014
Member
|
@dpshelio - could you write it such that it works with both Sphinx versions, using a |
8aab634 to
b365813
Compare
Contributor
Author
|
@astrofrog - I've updated the commit adding an |
… 1.2.3: module_name
b365813 to
3ee8991
Compare
Member
|
Couldn't you unpack to a tuple then select on the length rather than using try: except? |
Member
|
In any case, this patch needs to be submitted to astropy/astropy-helpers, as the |
This was referenced Sep 3, 2014
Contributor
Author
|
I'm closing this PR as astropy/astropy-helpers#79 or astropy/astropy-helpers#80 is solving this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I doubt this will pass the tests with the current version of sphinx installed by conda (v1.2.2) but when the new version become available (which is already through pip), a
ValueError: too many values to unpackwill be raised unless a new element is unpacked. This PR add an extra variable to unpack all the elements properly.In case you are interested, this was introduced in Sphinx by this commit