Skip to content

TST: switch dependency resolution for oldestdeps from lowest-direct to lowest#18913

Closed
neutrinoceros wants to merge 2 commits intoastropy:mainfrom
neutrinoceros:tst/lowest-deps-for-all
Closed

TST: switch dependency resolution for oldestdeps from lowest-direct to lowest#18913
neutrinoceros wants to merge 2 commits intoastropy:mainfrom
neutrinoceros:tst/lowest-deps-for-all

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

@neutrinoceros neutrinoceros commented Nov 14, 2025

Description

My preliminary testing suggests that this is now possible. Let's see if I missed anything.
Close #18782

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

TODO:

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

hum, so my preliminary test didn't include all extra deps, so I'm bound to find new stuff, and it's not so surprising that this doesn't work out of the box yet. What's weird however is that the first constraint I added doesn't seem to have any effect. It might be because aiohttp is only included as an optional dep of an optional dep, and that could be a bug in uv... I'll dig further into this some other day !

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

Ok I'm now convinced more work is needed. I'll figure out what's still missing on my private fork and I'll re-open this (or something similar) once I got a working proof of concept.

@neutrinoceros neutrinoceros deleted the tst/lowest-deps-for-all branch November 15, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: towards reproducible builds for oldestdeps

1 participant