Skip to content

Backport PR #18882 on branch v7.2.x (BUG: warn instead of raise when failing to read specific files in fitsdiff script)#18907

Merged
astrofrog merged 1 commit intoastropy:v7.2.xfrom
meeseeksmachine:auto-backport-of-pr-18882-on-v7.2.x
Nov 14, 2025
Merged

Backport PR #18882 on branch v7.2.x (BUG: warn instead of raise when failing to read specific files in fitsdiff script)#18907
astrofrog merged 1 commit intoastropy:v7.2.xfrom
meeseeksmachine:auto-backport-of-pr-18882-on-v7.2.x

Conversation

@meeseeksmachine
Copy link
Copy Markdown

Backport PR #18882: BUG: warn instead of raise when failing to read specific files in fitsdiff script

@lumberbot-app lumberbot-app bot added this to the v7.2.0 milestone Nov 13, 2025
@lumberbot-app lumberbot-app bot added io.fits Bug Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection backport-v7.2.x on-merge: backport to v7.2.x labels Nov 13, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim requested a review from astrofrog November 13, 2025 22:02
@astrofrog
Copy link
Copy Markdown
Member

Unfortunately this is causing all the wheel builds to fail - @neutrinoceros, any ideas?

@pllim
Copy link
Copy Markdown
Member

pllim commented Nov 13, 2025

Hmm looks like it is choking on an error message check but the log truncated the display.

assert err == f"Warning: failed to open {tmp} (or {Zfile}). Skipping.\n"

@neutrinoceros
Copy link
Copy Markdown
Contributor

you need #18901 first

@pllim
Copy link
Copy Markdown
Member

pllim commented Nov 13, 2025

Oh wait, here it is: E assert "Warning: fai...n continue\n" == 'Warning: fai.... Skipping.\n'

@neutrinoceros
Copy link
Copy Markdown
Contributor

(I've had the same problem while working on main, rebasing onto #18890 (backported as #18901) solved it)

@neutrinoceros
Copy link
Copy Markdown
Contributor

Note that you'll also need #18888 and #18892 if you want all extra CI to go green again (boy, what a week)

@neutrinoceros neutrinoceros force-pushed the auto-backport-of-pr-18882-on-v7.2.x branch from 198ed29 to 128db9c Compare November 14, 2025 11:39
@astrofrog astrofrog force-pushed the auto-backport-of-pr-18882-on-v7.2.x branch from 128db9c to f85f17f Compare November 14, 2025 14:19
@astrofrog astrofrog enabled auto-merge November 14, 2025 14:46
@astrofrog astrofrog merged commit 4136ed1 into astropy:v7.2.x Nov 14, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v7.2.x on-merge: backport to v7.2.x Bug Build all wheels Run all the wheel builds rather than just a selection Extra CI Run cron CI as part of PR io.fits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants