Skip to content

TST/DEP: add contourpy and pillow to the list of package we never want to build#18897

Merged
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/dep/no-build-package-additions
Nov 13, 2025
Merged

TST/DEP: add contourpy and pillow to the list of package we never want to build#18897
pllim merged 1 commit intoastropy:mainfrom
neutrinoceros:tst/dep/no-build-package-additions

Conversation

@neutrinoceros
Copy link
Copy Markdown
Contributor

@neutrinoceros neutrinoceros commented Nov 12, 2025

Description

ref: #18782
extracted from #18780
for reference, both contourpy and pillow are transitive (optional) dependencies via matplotlib, and contain compiled code, so it's wasteful to build them from source.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.0.0 milestone Nov 12, 2025
@neutrinoceros neutrinoceros added testing no-changelog-entry-needed dependencies Pull requests that update a dependency file labels Nov 12, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros changed the title TST/DEP: add contourpy and pillow to the list of package we never want to build TST/DEP: add contourpy and pillow to the list of package we never want to build Nov 12, 2025
@neutrinoceros neutrinoceros marked this pull request as ready for review November 12, 2025 18:49
Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only affects oldestdeps, right? Seems much simpler.

If this affects all jobs, we also need Extra CI.

@neutrinoceros
Copy link
Copy Markdown
Contributor Author

This affects all jobs, but should not have any visible effect right now.

@neutrinoceros neutrinoceros added the Extra CI Run cron CI as part of PR label Nov 12, 2025
@pllim pllim merged commit 1746f7d into astropy:main Nov 13, 2025
58 checks passed
@pllim
Copy link
Copy Markdown
Member

pllim commented Nov 13, 2025

CI all green. Merged. Thanks!

@neutrinoceros neutrinoceros deleted the tst/dep/no-build-package-additions branch November 13, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Extra CI Run cron CI as part of PR installation no-changelog-entry-needed testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants