TST/DEP: bump minimal requirement on pytest-xdist (2.5.0 -> 3.6.0)#18838
TST/DEP: bump minimal requirement on pytest-xdist (2.5.0 -> 3.6.0)#18838pllim merged 1 commit intoastropy:mainfrom
pytest-xdist (2.5.0 -> 3.6.0)#18838Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Welcome to Astropy 👋 and congratulations on your first pull request! 🎉 A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible. If you feel that this pull request has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail feedback@astropy.org. |
|
👋 Thank you for your draft pull request! Do you know that you can use |
pyproject.toml
Outdated
| "pytest-astropy-header>=0.2.1", | ||
| "pytest-astropy>=0.10.0", | ||
| "pytest-xdist>=2.5.0", | ||
| "pytest-xdist>=3.0.2", |
There was a problem hiding this comment.
the reason I'm bumping this package is that version 2.5.0 implicitly requires the py package, which used to be distributed with pytest (originally, py.test), but isn't part of pytest 8.0.0.
We are not capturing this problem in oldestdeps CI runs because it doesn't use pytest-xdist and runs all tests sequentially instead.
pyproject.toml
Outdated
|
|
||
| # via pytest-xdist | ||
| # this constraint can be removed once pytest-xdist>=3.6 or newer is required | ||
| "execnet>=1.9.0", |
There was a problem hiding this comment.
pytest-xdist 3.6 is only about 1.6 y.o. now, so I don't feel confortable bumping it so high yet, though there would be a precedent for doing this (we started requiring pytest 8.0 or newer only a year after it came out)
There was a problem hiding this comment.
As a pytest plugin, I don't think SPEC 0 applies. If it is cleaner to just bump the minversion higher so that we don't need this, I will be in support, FWIW.
There was a problem hiding this comment.
My understanding is that SPEC 0 is about runtime dependencies, not developer tooling, so it is not relevant here.
There was a problem hiding this comment.
So, are you guys saying I should just bump ?
a80ee53 to
979f5ee
Compare
pytest-xdist (2.5.0 -> 3.0.2) + add a constraint on execnetpytest-xdist (2.5.0 -> 3.6.0)
Description
ref: #18782
From where I'm standing this looks like one of the last required changes so make `oldestdeps` builds reproducible (in combination with #18780)